[CP Staging] Fix GetMissingOnyxMessages infinite loop when processing deferred updates - #41702
Merged
Conversation
arosiclair
requested review from
aldo-expensify and
luacmartins
and removed request for
amyevans
May 6, 2024 21:58
danieldoglas
approved these changes
May 6, 2024
luacmartins
approved these changes
May 6, 2024
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
aldo-expensify
approved these changes
May 6, 2024
OSBotify
pushed a commit
that referenced
this pull request
May 6, 2024
…loop [CP Staging] Fix GetMissingOnyxMessages infinite loop when processing deferred updates (cherry picked from commit a2172a1)
60 tasks
50 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.70-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.70-5 🚀
|
Contributor
|
@arosiclair i have been OOO for the last week or so. I see you mentioned me here. I think these changes look good and make sense! No comments from my side! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @chrispader
Details
Fixes infinite recursion when
clientLastUpdateIDtovalidateAndApplyDeferredUpdatesGetMissingOnyxMessagesfails to update thelastUpdateIDAppliedToClientFixed Issues
$ #41704
$ https://expensify.slack.com/archives/C0714QF3A1Z/p1715025547496549?thread_ts=1715021761.016969&cid=C0714QF3A1Z
Tests
Offline tests
None
QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop